From: Haozhong Zhang <haozhong.zhang@intel.com>
To: Bandan Das <bsd@redhat.com>
Cc: <kvm@vger.kernel.org>, Gleb Natapov <gleb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
<x86@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: nVMX: remove incorrect vpid check in nested invvpid emulation
Date: Thu, 26 Nov 2015 00:18:34 +0800 [thread overview]
Message-ID: <20151125161834.GA22092@hzzhang-OptiPlex-9020.sh.intel.com> (raw)
In-Reply-To: <jpgr3jehylb.fsf@linux.bootlegged.copy>
On 11/25/15 10:45, Bandan Das wrote:
> Haozhong Zhang <haozhong.zhang@intel.com> writes:
>
> > This patch removes the vpid check when emulating nested invvpid
> > instruction of type all-contexts invalidation. The existing code is
> > incorrect because:
> > (1) According to Intel SDM Vol 3, Section "INVVPID - Invalidate
> > Translations Based on VPID", invvpid instruction does not check
> > vpid in the invvpid descriptor when its type is all-contexts
> > invalidation.
>
> But iirc isn't vpid=0 reserved for root mode ?
Yes,
> I think we don't want
> L1 hypervisor to be able do a invvpid(0).
but the invvpid emulated here is doing the all-contexts invalidation that
does not use the given vpid and "invalidates all mappings tagged with all
VPIDs except VPID 0000H" (from Intel SDM).
>
> > (2) According to the same document, invvpid of type all-contexts
> > invalidation does not require there is an active VMCS, so/and
> > get_vmcs12() in the existing code may result in a NULL-pointer
> > dereference. In practice, it can crash both KVM itself and L1
> > hypervisors that use invvpid (e.g. Xen).
>
> If that is the case, then just check if it's null and return without
> doing anything.
(according to Intel SDM) invvpid of type all-contexts invalidation
should not trigger a valid vmx fail if vpid in the current VMCS is 0.
However, this check and its following operation do change this semantics
in nested VMX, so it should be completely removed.
>
> > Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
> > ---
> > arch/x86/kvm/vmx.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> > index 87acc52..af823a3 100644
> > --- a/arch/x86/kvm/vmx.c
> > +++ b/arch/x86/kvm/vmx.c
> > @@ -7394,11 +7394,6 @@ static int handle_invvpid(struct kvm_vcpu *vcpu)
> >
> > switch (type) {
> > case VMX_VPID_EXTENT_ALL_CONTEXT:
> > - if (get_vmcs12(vcpu)->virtual_processor_id == 0) {
> > - nested_vmx_failValid(vcpu,
> > - VMXERR_INVALID_OPERAND_TO_INVEPT_INVVPID);
> > - return 1;
> > - }
> > __vmx_flush_tlb(vcpu, to_vmx(vcpu)->nested.vpid02);
> > nested_vmx_succeed(vcpu);
> > break;
>
> I also noticed a BUG() here in the default. It might be a good idea to replace
> it with a WARN.
Or, in nested_vmx_setup_ctls_msrs():
if (enable_vpid)
- vmx->nested.nested_vmx_vpid_caps = VMX_VPID_INVVPID_BIT |
- VMX_VPID_EXTENT_GLOBAL_CONTEXT_BIT;
+ vmx->nested.nested_vmx_vpid_caps = VMX_VPID_EXTENT_GLOBAL_CONTEXT_BIT;
because the current handle_invvpid() only handles all-contexts invalidation.
Haozhong
next prev parent reply other threads:[~2015-11-25 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 9:21 Haozhong Zhang
2015-11-25 15:45 ` Bandan Das
2015-11-25 16:18 ` Haozhong Zhang [this message]
2015-11-25 16:36 ` Bandan Das
2015-11-25 16:21 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151125161834.GA22092@hzzhang-OptiPlex-9020.sh.intel.com \
--to=haozhong.zhang@intel.com \
--cc=bsd@redhat.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®