From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753066AbbKYQz1 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 Nov 2015 11:55:27 -0500
Received: from down.free-electrons.com ([37.187.137.238]:51750 "EHLO
	mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751606AbbKYQzZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 Nov 2015 11:55:25 -0500
Date: Wed, 25 Nov 2015 17:55:22 +0100
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
        Andrew Lunn <andrew@lunn.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
        linux-arm-kernel@lists.infradead.org, Lior Amsalem <alior@marvell.com>,
        Nadav Haklai <nadavh@marvell.com>, Marcin Wojtas <mw@semihalf.com>,
        Simon Guinot <simon.guinot@sequanux.org>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Boris BREZILLON <boris.brezillon@free-electrons.com>,
        Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH net-next 3/3] net: mvneta: Add naive RSS support
Message-ID: <20151125175522.0e8dd8b8@free-electrons.com>
In-Reply-To: <1448463243-21057-4-git-send-email-gregory.clement@free-electrons.com>
References: <1448463243-21057-1-git-send-email-gregory.clement@free-electrons.com>
	<1448463243-21057-4-git-send-email-gregory.clement@free-electrons.com>
Organization: Free Electrons
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Gregory,

On Wed, 25 Nov 2015 15:54:03 +0100, Gregory CLEMENT wrote:

>  	pp->rxq_def = rxq_def;
>  
> +	pp->indir[0] = rxq_def;

So now we have the RX queue in both pp->rxq_def and pp->indir[0] ? Is
this really useful ?

Also, if the RX queue becomes a per-port definition, why do you keep
the global rxq_def variable ?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com