From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752012AbbKZNWs (ORCPT ); Thu, 26 Nov 2015 08:22:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:40686 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751016AbbKZNWo (ORCPT ); Thu, 26 Nov 2015 08:22:44 -0500 Date: Thu, 26 Nov 2015 14:22:40 +0100 From: Jan Kara To: kbuild test robot Cc: Jan Kara , kbuild-all@01.org, axboe@kernel.dk, Jeff Moyer , LKML , Tejun Heo , Jan Kara Subject: Re: [PATCH 4/4] cfq-iosched: Allow parent cgroup to preempt its child Message-ID: <20151126132240.GC9919@quack.suse.cz> References: <1448461351-22481-5-git-send-email-jack@suse.cz> <201511260459.yzWTWt80%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: <201511260459.yzWTWt80%fengguang.wu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu 26-11-15 04:24:23, kbuild test robot wrote: > Hi Jan, > > [auto build test ERROR on block/for-next] > [also build test ERROR on v4.4-rc2 next-20151124] > > url: https://github.com/0day-ci/linux/commits/Jan-Kara/SYNC_NOIDLE-preemption-for-ancestor-cgroups/20151125-222645 > base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next > config: i386-allmodconfig (attached as .config) > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > > >> ERROR: "cgroup_is_descendant" undefined! Ah, I didn't notice the function is not exported. Attached patch fixes the build. Honza -- Jan Kara SUSE Labs, CR --liOOAslEiF7prFVr Content-Type: text/x-patch; charset=us-ascii Content-Disposition: attachment; filename="0001-cgroup-Export-cgroup_is_descendant.patch" >>From 9a489728dbae48311e2ee0fff3c1793dd1e97392 Mon Sep 17 00:00:00 2001 From: Jan Kara Date: Thu, 26 Nov 2015 13:29:21 +0100 Subject: [PATCH] cgroup: Export cgroup_is_descendant() CFQ IO scheduler will use cgroup_is_descendant() to decide whether one queue can preempt another once. Signed-off-by: Jan Kara --- kernel/cgroup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/cgroup.c b/kernel/cgroup.c index f1603c153890..6b61f847b040 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ -477,6 +477,7 @@ bool cgroup_is_descendant(struct cgroup *cgrp, struct cgroup *ancestor) } return false; } +EXPORT_SYMBOL_GPL(cgroup_is_descendant); static int notify_on_release(const struct cgroup *cgrp) { -- 2.1.4 --liOOAslEiF7prFVr--