From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752201AbbKZPAw (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Nov 2015 10:00:52 -0500
Received: from mail-pa0-f47.google.com ([209.85.220.47]:33323 "EHLO
	mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751165AbbKZPAu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Nov 2015 10:00:50 -0500
Date: Fri, 27 Nov 2015 00:00:18 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, Kan Liang <kan.liang@intel.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 2/3] perf callchain: Stop resolving callchains after
 invalid address
Message-ID: <20151126150018.GA21474@danjae.kornet>
References: <1448521700-32062-1-git-send-email-namhyung@kernel.org>
 <1448521700-32062-2-git-send-email-namhyung@kernel.org>
 <565705D1.705@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <565705D1.705@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi David,

On Thu, Nov 26, 2015 at 06:14:57AM -0700, David Ahern wrote:
> On 11/26/15 12:08 AM, Namhyung Kim wrote:
> >@@ -528,11 +529,16 @@ int main(int argc, const char **argv)
> >  {
> >  	const char *cmd;
> >  	char sbuf[STRERR_BUFSIZE];
> >+	int min_addr;
> >
> >  	/* The page_size is placed in util object. */
> >  	page_size = sysconf(_SC_PAGE_SIZE);
> >  	cacheline_size = sysconf(_SC_LEVEL1_DCACHE_LINESIZE);
> >
> >+	if (sysctl__read_int("vm/mmap_min_addr", &min_addr) < 0)
> 
> This assumes the record and analysis are done on the same system.

Right.  Maybe we can just use minimal size (or page size?) or save and
pass it through somewhere in the feature bit?

Thanks,
Namhyung