From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753421AbbKZSL4 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Nov 2015 13:11:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42642 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752442AbbKZSLx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Nov 2015 13:11:53 -0500
Date: Thu, 26 Nov 2015 19:11:49 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Wang Nan <wangnan0@huawei.com>,
        lkml <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 2/3] perf build: Use FEATURE-INCLUDE in bpf subproject
Message-ID: <20151126181149.GA19410@krava.brq.redhat.com>
References: <1448546044-28973-1-git-send-email-jolsa@kernel.org>
 <1448546044-28973-2-git-send-email-jolsa@kernel.org>
 <20151126163130.GH2945@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151126163130.GH2945@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 26, 2015 at 01:31:30PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Nov 26, 2015 at 02:54:03PM +0100, Jiri Olsa escreveu:
> > Using FEATURE-INCLUDE in bpf subproject in case bpf is built
> > via perf. Keep the current features detection for other cases.
> > 
> > Cc: Wang Nan <wangnan0@huawei.com>
> > Link: http://lkml.kernel.org/n/tip-utuczk899ckz6qtggqvhm7yu@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> 
> Clashes with:
> 
> d8ad6a15cc3a ("tools lib bpf: Don't do a feature check when cleaning")
> 
> That has, at that point:
> 
> +check_feat := 1
> +NON_CHECK_FEAT_TARGETS := clean TAGS tags cscope help
> +ifdef MAKECMDGOALS
> +ifeq ($(filter-out $(NON_CHECK_FEAT_TARGETS),$(MAKECMDGOALS)),)
> +  check_feat := 0
> +endif
> +endif
> +
> +ifeq ($(check_feat),1)
>  include $(srctree)/tools/build/Makefile.feature
> +endif

I see, please take that one, I'll rebase my changes over that

we still need more comments/feedback on that anyway ;-)

jirka