From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189AbbKZTtQ (ORCPT ); Thu, 26 Nov 2015 14:49:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54985 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065AbbKZTtN (ORCPT ); Thu, 26 Nov 2015 14:49:13 -0500 Date: Thu, 26 Nov 2015 20:49:10 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Steven Rostedt , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra Subject: Re: [PATCH 2/3] perf: Move exclude_kernel tracepoint check to init event Message-ID: <20151126194910.GA26579@krava.brq.redhat.com> References: <1448566489-25922-1-git-send-email-jolsa@kernel.org> <1448566489-25922-3-git-send-email-jolsa@kernel.org> <20151126194106.GH28162@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151126194106.GH28162@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2015 at 04:41:06PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 26, 2015 at 08:34:48PM +0100, Jiri Olsa escreveu: > > We suppress events with attr::exclude_kernel set when > > the event is generated, so following capture will > > give no warning and produce no data: > > > > $ sudo perf record -e sched:sched_switch:u ls > > $ sudo /perf script | wc -l > > 0 > > > > Checking the attr::exclude_kernel at the event init > > time and failing right away: > > We can as well provide a better warning in the tooling side and don't > even ask this nonsensical combo to the kernel, right? yep.. I'll update my todo ;-) > > Arguably the kernel was doing what was asked for, its just that no > sched:sched_switch took place while in user space... ;-) I think it's better to fail like that.. rather than spending time on figuring why my test did not give me any data ;-) jirka