From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752200AbbK2SMt (ORCPT ); Sun, 29 Nov 2015 13:12:49 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:56434 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743AbbK2SMr (ORCPT ); Sun, 29 Nov 2015 13:12:47 -0500 Date: Sun, 29 Nov 2015 10:12:45 -0800 From: Gregkh To: jpage@tutanota.de Cc: linux-kernel@vger.kernel.org, Jason Subject: Re: [PATCH] staging: skein: Adds test vectors & cleans up maros Message-ID: <20151129181245.GA27950@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 29, 2015 at 12:51:30PM +0000, jpage@tutanota.de wrote: > The patch for cleaning up the Skein hash implementation is included below. > > The test & pass vectors for the hash function have been included, but not > checked as the competition is still ongoing,as the final specification is > unknown at this time. > > The files are verbatim lifted from the author's website (https:// > www.schneier.com/code/skein_NIST_CD_102610.zip). > The changes provide by me are moving all macros in the .c files to their > repective .h files. As this was strictly a cosmetic change, I have not tested > it with a rebuild. > > This patch helps move the Skein driver along towards completion. > > A signed version of this patch is included in the attachments. > Also, please sign my attached GPG Key, if possible. > Thank you. > Signed-off-by: Sanidhya Solanki > Lots of this should be below in the changelog itself, the patch should be "self-contained" and not need to be hand-edited in order to be applied. > > commit 6d50eca21b913f47899d9b91413968b8bccb6e31 > Author: Sanidhya Solanki > Date: Fri Nov 27 01:54:23 2015 -0500 Why is this all here? Please use git send-email to send a patch if your email client can't just send them directly. > > - Added Test files. > - Moved macros to appropriate Header Files. > - Cleaned up TODO & added contact information. > - Passing Test Vectors remains. > - Adding module support remains. That's a lot of different things all at once, please break this up into a patch series, each one doing only one thing. > > Changes to be committed: > modified: drivers/staging/skein/TODO > modified: drivers/staging/skein/skein_block.c > copied: drivers/staging/skein/skein_block.c -> drivers/staging/ > skein/skein_block.h > new file: drivers/staging/skein/skein_test.c > new file: drivers/staging/skein/skein_test.h What is all of these lines for? And you don't have a signed-off-by in the patch body itself. My scripts warned you about all of the above last time, why didn't you pay attention to them? And finally, please use scripts/get_maintainer.pl to determine the correct people and mailing lists to send a patch to. hope this helps, greg k-h