From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752386AbbK3DIL (ORCPT ); Sun, 29 Nov 2015 22:08:11 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:60959 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbbK3DII (ORCPT ); Sun, 29 Nov 2015 22:08:08 -0500 Date: Sun, 29 Nov 2015 19:08:02 -0800 From: Andrew Morton To: Cc: , , , , , Subject: Re: [PATCH] bugfix oom kill init lead panic Message-Id: <20151129190802.dc66cf35.akpm@linux-foundation.org> In-Reply-To: <1448880869-20506-1-git-send-email-chenjie6@huawei.com> References: <1448880869-20506-1-git-send-email-chenjie6@huawei.com> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Nov 2015 18:54:29 +0800 wrote: > From: chenjie > > when oom happened we can see: > Out of memory: Kill process 9134 (init) score 3 or sacrifice child > Killed process 9134 (init) total-vm:1868kB, anon-rss:84kB, file-rss:572kB > Kill process 1 (init) sharing same memory > ... > Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000009 > > That's because: > the busybox init will vfork a process,oom_kill_process found > the init not the children,their mm is the same when vfork. > > ... > > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -513,7 +513,7 @@ void oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order, > rcu_read_lock(); > for_each_process(p) > if (p->mm == mm && !same_thread_group(p, victim) && > - !(p->flags & PF_KTHREAD)) { > + !(p->flags & PF_KTHREAD) && !is_global_init(p)) { > if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN) > continue; What kernel version are you using? I don't think this can happen in current code...