From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752602AbbK2UNa (ORCPT ); Sun, 29 Nov 2015 15:13:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54440 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752510AbbK2UN1 (ORCPT ); Sun, 29 Nov 2015 15:13:27 -0500 Date: Sun, 29 Nov 2015 21:13:24 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Linux Kernel Mailing List , masami.hiramatsu.pt@hitachi.com, David Ahern Subject: Re: perf test unwind failing Message-ID: <20151129201324.GB1570@krava.brq.redhat.com> References: <20151126204559.GM28162@kernel.org> <20151127082121.GA24503@krava.brq.redhat.com> <20151127160311.GD5934@kernel.org> <20151127161740.GG5934@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151127161740.GG5934@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 27, 2015 at 01:17:40PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Nov 27, 2015 at 01:03:11PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Nov 27, 2015 at 09:21:21AM +0100, Jiri Olsa escreveu: > > > On Thu, Nov 26, 2015 at 05:45:59PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Can you take a look at 'perf test unwind'? It is failing in my > > > > perf/core branch, no time to bisect that now. > > See above. > > > > After reading the patch I see why you refer to that patch, it is just > > that at machine__exit() one should free the kernel maps if they were > > created, so it calls machine__destroy_kernel_maps(), and that will check > > if the maps were allocated, if not, nothing will be done. > > > > Anyway, I applied your patch, it fixes the problem, thanks! > > Applied this one to my local tree: cool, thanks jirka > > From 9bdcede563a831f139b5fc872f028ef844a7462e Mon Sep 17 00:00:00 2001 > From: Jiri Olsa > Date: Fri, 27 Nov 2015 09:21:21 +0100 > Subject: [PATCH 1/1] perf test: 'unwind' test should create kernel maps > > The 'perf test unwind' is failing because it forgot to create the kernel > maps, fix it. > > After the patch: > > # perf test unwind > 40: Test dwarf unwind : Ok > > Reported-and-Tested-by: Arnaldo Carvalho de Melo > Signed-off-by: Jiri Olsa > Cc: David Ahern > Cc: Masami Hiramatsu > Cc: Namhyung Kim > Link: http://lkml.kernel.org/r/20151127082121.GA24503@krava.brq.redhat.com > Signed-off-by: Arnaldo Carvalho de Melo > --- > tools/perf/tests/dwarf-unwind.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/perf/tests/dwarf-unwind.c b/tools/perf/tests/dwarf-unwind.c > index b2357e8115a2..3cce13b19cbb 100644 > --- a/tools/perf/tests/dwarf-unwind.c > +++ b/tools/perf/tests/dwarf-unwind.c > @@ -173,6 +173,11 @@ int test__dwarf_unwind(int subtest __maybe_unused) > return -1; > } > > + if (machine__create_kernel_maps(machine)) { > + pr_err("Failed to create kernel maps\n"); > + return -1; > + } > + > callchain_param.record_mode = CALLCHAIN_DWARF; > > if (init_live_machine(machine)) { > -- > 2.1.0 >