From: Herbert Xu <herbert@gondor.apana.org.au>
To: Rameshwar Sahu <rsahu@apm.com>
Cc: davem@davemloft.net, Vinod Koul <vinod.koul@intel.com>,
dan.j.williams@intel.com, dmaengine@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jcm@redhat.com,
patches@apm.com, linux-crypto@vger.kernel.org,
Kaustubh Gondkar <kgondkar@apm.com>
Subject: Re: [PATCH v2 0/3] dmaengine: Add supports for APM X-Gene SoC CRC32C accerlerator driver
Date: Mon, 30 Nov 2015 16:39:50 +0800 [thread overview]
Message-ID: <20151130083950.GA7792@gondor.apana.org.au> (raw)
In-Reply-To: <CAFd313zqimQtG8epeo3U7gzxWRf0hqO4K8hOFy4UK-6pG5GcJg@mail.gmail.com>
On Mon, Nov 30, 2015 at 02:06:03PM +0530, Rameshwar Sahu wrote:
> On Mon, Nov 16, 2015 at 2:42 PM, <rsahu@apm.com> wrote:
> > From: Rameshwar Prasad Sahu <rsahu@apm.com>
> >
> > This patch implements support for APM X-Gene SoC CRC32C h/w accelerator driver
> > and adds CRC32C computations support in dmaengine framework. APM X-Gene SoC has
> > DMA engine capable of performing CRC32C computations.
> >
> > v2 changes:
> > 1. Added helper function in dmaengine framework
> > 2. Documented CRC32C support in Documentations/dmaengine/provider.txt
> > 3. Fixed algo name
> > 4. Fixed coding style issues
> >
> > Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com>
> > ---
> >
> > Rameshwar Prasad Sahu (3):
> > dmaengine: Add support for new feature CRC32C computations
> > dmaengine: xgene-dma: Add support for CRC32C computations via DMA
> > engine
> > Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver
> >
> > Documentation/dmaengine/provider.txt | 3 +
> > drivers/crypto/Kconfig | 8 +
> > drivers/crypto/Makefile | 1 +
> > drivers/crypto/xgene-crc32c.c | 234 +++++++++++++++++++++++++
> > drivers/dma/dmaengine.c | 2 +
> > drivers/dma/xgene-dma.c | 314 ++++++++++++++++++++++++++++++++--
> > include/linux/dmaengine.h | 13 ++
> > 7 files changed, 560 insertions(+), 15 deletions(-)
> > create mode 100755 drivers/crypto/xgene-crc32c.c
>
> Any Comments on above patchset ??
The main user of crc32c is lib/libcrc32c.c. Unfortunately it is
entire synchronous so it won't be able to use your crc32c driver
at all.
So who is going to be using this?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-11-30 8:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 9:12 rsahu
2015-11-30 8:36 ` Rameshwar Sahu
2015-11-30 8:39 ` Herbert Xu [this message]
2015-11-30 8:49 ` Rameshwar Sahu
2015-11-30 8:50 ` Herbert Xu
2015-11-30 8:57 ` Rameshwar Sahu
2015-12-09 8:25 ` Rameshwar Sahu
2015-12-09 8:27 ` Herbert Xu
2015-12-09 8:43 ` Rameshwar Sahu
2015-12-09 8:44 ` Herbert Xu
2015-12-09 17:37 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2015-11-16 9:08 rsahu
2015-11-07 16:37 Rameshwar Prasad Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130083950.GA7792@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=kgondkar@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@apm.com \
--cc=rsahu@apm.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®