From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753523AbbK3JD0 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Nov 2015 04:03:26 -0500
Received: from casper.infradead.org ([85.118.1.10]:45070 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752639AbbK3JDS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Nov 2015 04:03:18 -0500
Date: Mon, 30 Nov 2015 10:03:13 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] sched: Move sched_to_prio arrays out of line
Message-ID: <20151130090313.GE17308@twins.programming.kicks-ass.net>
References: <1448859583-3252-1-git-send-email-andi@firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1448859583-3252-1-git-send-email-andi@firstfloor.org>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Nov 29, 2015 at 08:59:43PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> When building a kernel with a gcc 6 snapshot the compiler complains
> about unused const static variables for prio_to_weight and prio_to_mult
> for multiple scheduler files (all but core.c and autogroup.c)
> 
> The way the array is currently declared it will be duplicated in
> every scheduler file that includes sched.h, which seems rather wasteful.

Yeah, that's not right.

> Move the array out of line into core.c. I also added a sched_ prefix
> to avoid any potential name space collisions.

Thanks!