From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754589AbbK3PG1 (ORCPT ); Mon, 30 Nov 2015 10:06:27 -0500 Received: from mail-yk0-f169.google.com ([209.85.160.169]:34482 "EHLO mail-yk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754501AbbK3PGY (ORCPT ); Mon, 30 Nov 2015 10:06:24 -0500 Date: Mon, 30 Nov 2015 10:06:21 -0500 From: Tejun Heo To: Mikulas Patocka Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sata_sil: disable trim Message-ID: <20151130150621.GE3535@mtj.duckdns.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2015 at 12:00:59PM -0500, Mikulas Patocka wrote: > When I connect an Intel SSD to SATA SIL controller (PCI ID 1095:3114), any > TRIM command results in I/O errors being reported in the log. There is > other similar error reported with TRIM and the SIL controller: > https://bugs.centos.org/view.php?id=5880 > > Apparently the controller doesn't support TRIM commands. This patch > disables TRIM support on the SATA SIL controller. > > ata7.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x0 > ata7.00: BMDMA2 stat 0x50001 > ata7.00: failed command: DATA SET MANAGEMENT > ata7.00: cmd 06/01:01:00:00:00/00:00:00:00:00/a0 tag 0 dma 512 out > res 51/04:01:00:00:00/00:00:00:00:00/a0 Emask 0x1 (device error) > ata7.00: status: { DRDY ERR } > ata7.00: error: { ABRT } > ata7.00: device reported invalid CHS sector 0 > sd 8:0:0:0: [sdb] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE > sd 8:0:0:0: [sdb] tag#0 Sense Key : Illegal Request [current] [descriptor] > sd 8:0:0:0: [sdb] tag#0 Add. Sense: Unaligned write command > sd 8:0:0:0: [sdb] tag#0 CDB: Write same(16) 93 08 00 00 00 00 00 21 95 88 00 20 00 00 00 00 > blk_update_request: I/O error, dev sdb, sector 2200968 > > Signed-off-by: Mikulas Patocka > Cc: stable@kernel.org Applied to libata/for-4.4-fixes. Thanks. -- tejun