From: Guenter Roeck <linux@roeck-us.net>
To: Mikael Starvik <starvik@axis.com>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>,
linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cris: debugport: Fix section mismatches
Date: Mon, 30 Nov 2015 07:19:41 -0800 [thread overview]
Message-ID: <20151130151941.GA32679@roeck-us.net> (raw)
In-Reply-To: <1447193076-16755-1-git-send-email-linux@roeck-us.net>
On Tue, Nov 10, 2015 at 02:04:35PM -0800, Guenter Roeck wrote:
> Section mismatches can now cause build failures, such as for
> cris:allnoconfig. Rename affected variables to end with _console
> to make section mismatch checks happy.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Folks,
is there any interest picking up those patches or fixing the problems
by some other means ? If not, please let me know, and I'll drop
cris:allnoconfig from my list of build tests.
Thanks,
Guenter
> ---
> arch/cris/arch-v10/kernel/debugport.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/arch/cris/arch-v10/kernel/debugport.c b/arch/cris/arch-v10/kernel/debugport.c
> index 7d307cce8bd8..b6549e54be29 100644
> --- a/arch/cris/arch-v10/kernel/debugport.c
> +++ b/arch/cris/arch-v10/kernel/debugport.c
> @@ -468,7 +468,7 @@ etrax_console_device(struct console* co, int *index)
> #endif
> }
>
> -static struct console sercons = {
> +static struct console ser_console = {
> name : "ttyS",
> write: console_write,
> read : NULL,
> @@ -480,7 +480,7 @@ static struct console sercons = {
> cflag : 0,
> next : NULL
> };
> -static struct console sercons0 = {
> +static struct console ser0_console = {
> name : "ttyS",
> write: console_write,
> read : NULL,
> @@ -493,7 +493,7 @@ static struct console sercons0 = {
> next : NULL
> };
>
> -static struct console sercons1 = {
> +static struct console ser1_console = {
> name : "ttyS",
> write: console_write,
> read : NULL,
> @@ -505,7 +505,7 @@ static struct console sercons1 = {
> cflag : 0,
> next : NULL
> };
> -static struct console sercons2 = {
> +static struct console ser2_console = {
> name : "ttyS",
> write: console_write,
> read : NULL,
> @@ -517,7 +517,7 @@ static struct console sercons2 = {
> cflag : 0,
> next : NULL
> };
> -static struct console sercons3 = {
> +static struct console ser3_console = {
> name : "ttyS",
> write: console_write,
> read : NULL,
> @@ -539,17 +539,17 @@ init_etrax_debug(void)
> static int first = 1;
>
> if (!first) {
> - unregister_console(&sercons);
> - register_console(&sercons0);
> - register_console(&sercons1);
> - register_console(&sercons2);
> - register_console(&sercons3);
> + unregister_console(&ser_console);
> + register_console(&ser0_console);
> + register_console(&ser1_console);
> + register_console(&ser2_console);
> + register_console(&ser3_console);
> init_dummy_console();
> return 0;
> }
>
> first = 0;
> - register_console(&sercons);
> + register_console(&ser_console);
> start_port(port);
> #ifdef CONFIG_ETRAX_KGDB
> start_port(kgdb_port);
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
next prev parent reply other threads:[~2015-11-30 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 22:04 Guenter Roeck
2015-11-10 22:04 ` [PATCH 2/2] cris: Fix section mismatches in architecture startup code Guenter Roeck
2015-11-30 15:19 ` Guenter Roeck [this message]
2015-12-15 4:41 ` [PATCH 1/2] cris: debugport: Fix section mismatches Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130151941.GA32679@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jesper.nilsson@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome