From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755132AbbLAAKG (ORCPT ); Mon, 30 Nov 2015 19:10:06 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:35805 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbbLAAKF (ORCPT ); Mon, 30 Nov 2015 19:10:05 -0500 Date: Mon, 30 Nov 2015 16:10:04 -0800 From: Andrew Morton To: Sergey Senozhatsky Cc: Minchan Kim , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 1/2] zram: pass gfp from zcomp frontend to backend Message-Id: <20151130161004.171a80a7f618a2c55ff885c6@linux-foundation.org> In-Reply-To: <1448598194-24754-2-git-send-email-sergey.senozhatsky@gmail.com> References: <1448598194-24754-1-git-send-email-sergey.senozhatsky@gmail.com> <1448598194-24754-2-git-send-email-sergey.senozhatsky@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Nov 2015 13:23:13 +0900 Sergey Senozhatsky wrote: > From: Minchan Kim > > Each zcomp backend uses own gfp flag but it's pointless > because the context they could be called is driven by upper > layer(ie, zcomp frontend). As well, zcomp frondend could > call them in different context. One context(ie, zram init part) > is it should be better to make sure successful allocation > other context(ie, further stream allocation part for accelarating > I/O speed) is just optional so let's pass gfp down from driver > (ie, zcomp frontend) like normal MM convention. > > [sergey: add missing __vmalloc zero and highmem gfps] > Signed-off-by: Minchan Kim > Acked-by: Sergey Senozhatsky I changed this to signed-off-by:you. Documentation/SubmittingPatches section 11 explains why ;) (Hm, rule (c) is recursive. Nice!)