From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754206AbbK3RQz (ORCPT ); Mon, 30 Nov 2015 12:16:55 -0500 Received: from mga02.intel.com ([134.134.136.20]:57831 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbbK3RQy (ORCPT ); Mon, 30 Nov 2015 12:16:54 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,365,1444719600"; d="scan'208";a="863400493" Date: Mon, 30 Nov 2015 09:16:30 -0800 From: Andi Kleen To: Peter Zijlstra Cc: Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched: Move sched_to_prio arrays out of line Message-ID: <20151130171630.GB3528@tassilo.jf.intel.com> References: <1448859583-3252-1-git-send-email-andi@firstfloor.org> <20151130090313.GE17308@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151130090313.GE17308@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 30, 2015 at 10:03:13AM +0100, Peter Zijlstra wrote: > On Sun, Nov 29, 2015 at 08:59:43PM -0800, Andi Kleen wrote: > > From: Andi Kleen > > > > When building a kernel with a gcc 6 snapshot the compiler complains > > about unused const static variables for prio_to_weight and prio_to_mult > > for multiple scheduler files (all but core.c and autogroup.c) > > > > The way the array is currently declared it will be duplicated in > > every scheduler file that includes sched.h, which seems rather wasteful. > > Yeah, that's not right. > > > Move the array out of line into core.c. I also added a sched_ prefix > > to avoid any potential name space collisions. > > Thanks! Thanks. Please make sure the merge v2, v1 had one missing conversion. -Andi -- ak@linux.intel.com -- Speaking for myself only