mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: rweikusat@mobileactivedefense.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] unix: use wq_has_sleeper in unix_dgram_recvmsg
Date: Tue, 01 Dec 2015 14:48:03 -0500 (EST)	[thread overview]
Message-ID: <20151201.144803.593589376680817466.davem@davemloft.net> (raw)
In-Reply-To: <874mg8lg4c.fsf@doppelsaurus.mobileactivedefense.com>

From: Rainer Weikusat <rweikusat@mobileactivedefense.com>
Date: Thu, 26 Nov 2015 19:23:15 +0000

> The current unix_dgram_recvmsg does a wake up for every received
> datagram. This seems wasteful as only SOCK_DGRAM client sockets in an
> n:1 association with a server socket will ever wait because of the
> associated condition. The patch below changes the function such that the
> wake up only happens if wq_has_sleeper indicates that someone actually
> wants to be notified. Testing with SOCK_SEQPACKET and SOCK_DGRAM socket
> seems to confirm that this is an improvment.
> 
> Signed-Off-By: Rainer Weikusat <rweikusat@mobileactivedefense.com>

Applied, thanks.

      reply	other threads:[~2015-12-01 19:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 19:19 unix_dgram_recvmsg wakeups [test results & programs] Rainer Weikusat
2015-11-26 19:23 ` [PATCH] unix: use wq_has_sleeper in unix_dgram_recvmsg Rainer Weikusat
2015-12-01 19:48   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151201.144803.593589376680817466.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rweikusat@mobileactivedefense.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®