From: David Miller <davem@davemloft.net>
To: vkuznets@redhat.com
Cc: netdev@vger.kernel.org, kys@microsoft.com,
haiyangz@microsoft.com, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org
Subject: Re: [PATCH net-next] hv_netvsc: rework link status change handling
Date: Tue, 01 Dec 2015 15:03:59 -0500 (EST) [thread overview]
Message-ID: <20151201.150359.1001330212099906860.davem@davemloft.net> (raw)
In-Reply-To: <1448620795-8572-1-git-send-email-vkuznets@redhat.com>
From: Vitaly Kuznetsov <vkuznets@redhat.com>
Date: Fri, 27 Nov 2015 11:39:55 +0100
> There are several issues in hv_netvsc driver with regards to link status
> change handling:
> - RNDIS_STATUS_NETWORK_CHANGE results in calling userspace helper doing
> '/etc/init.d/network restart' and this is inappropriate and broken for
> many reasons.
> - link_watch infrastructure only sends one notification per second and
> in case of e.g. paired disconnect/connect events we get only one
> notification with last status. This makes it impossible to handle such
> situations in userspace.
>
> Redo link status changes handling in the following way:
> - Create a list of reconfig events in network device context.
> - On a reconfig event add it to the list of events and schedule
> netvsc_link_change().
> - In netvsc_link_change() ensure 2-second delay between link status
> changes.
> - Handle RNDIS_STATUS_NETWORK_CHANGE as a paired disconnect/connect event.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Applied, thank you.
prev parent reply other threads:[~2015-12-01 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 10:39 Vitaly Kuznetsov
2015-12-01 20:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201.150359.1001330212099906860.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®