From: David Miller <davem@davemloft.net>
To: razor@blackwall.org
Cc: linux-kernel@vger.kernel.org, shm@cumulusnetworks.com,
gospo@cumulusnetworks.com, roopa@cumulusnetworks.com,
dsa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
akinobu.mita@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: add support for netdev notifier error injection
Date: Tue, 01 Dec 2015 15:32:39 -0500 (EST) [thread overview]
Message-ID: <20151201.153239.181267823939116963.davem@davemloft.net> (raw)
In-Reply-To: <1448714728-12729-1-git-send-email-razor@blackwall.org>
From: Nikolay Aleksandrov <razor@blackwall.org>
Date: Sat, 28 Nov 2015 13:45:28 +0100
> From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
> This module allows to insert errors in some of netdevice's notifier
> events. All network drivers use these notifiers to signal various events
> and to check if they are allowed, e.g. PRECHANGEMTU and CHANGEMTU
> afterwards. Until recently I had to run failure tests by injecting
> a custom module, but now this infrastructure makes it trivial to test
> these failure paths. Some of the recent bugs I fixed were found using
> this module.
> Here's an example:
> $ cd /sys/kernel/debug/notifier-error-inject/netdev
> $ echo -22 > actions/NETDEV_CHANGEMTU/error
> $ ip link set eth0 mtu 1024
> RTNETLINK answers: Invalid argument
>
> CC: Akinobu Mita <akinobu.mita@gmail.com>
> CC: "David S. Miller" <davem@davemloft.net>
> CC: netdev <netdev@vger.kernel.org>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
This looks fine, applied to net-next, thanks!
prev parent reply other threads:[~2015-12-01 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 12:45 Nikolay Aleksandrov
2015-11-30 23:48 ` Akinobu Mita
2015-11-30 23:49 ` Nikolay Aleksandrov
2015-12-01 20:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201.153239.181267823939116963.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akinobu.mita@gmail.com \
--cc=dsa@cumulusnetworks.com \
--cc=gospo@cumulusnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=razor@blackwall.org \
--cc=roopa@cumulusnetworks.com \
--cc=shm@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®