From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932090AbbLAVHN (ORCPT ); Tue, 1 Dec 2015 16:07:13 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:57230 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755206AbbLAVHL (ORCPT ); Tue, 1 Dec 2015 16:07:11 -0500 Date: Tue, 01 Dec 2015 16:07:09 -0500 (EST) Message-Id: <20151201.160709.566323664243976564.davem@davemloft.net> To: arnd@arndb.de Cc: isdn@linux-pingi.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] isdn: remove spellcaster driver From: David Miller In-Reply-To: <2948626.r4RdgunA3R@wuerfel> References: <2948626.r4RdgunA3R@wuerfel> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Dec 2015 13:07:11 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 30 Nov 2015 11:34:09 +0100 > The 'sc' ISDN driver relies on using readl() to access ISA I/O memory. > This has been deprecated and produced warnings since linux-2.3.23, > disabled by default since 2.4.10 and finally removed in 2.6.5. > > I found this because the compiling the driver for ARM produces > a warning: > > In file included from ../drivers/isdn/sc/includes.h:8:0, > from ../drivers/isdn/sc/init.c:13: > ../arch/arm/include/asm/io.h:115:21: note: expected 'const volatile void *' but argument is of type 'long unsigned int' > > It is pretty clear that this driver has not been used for a long time > and there is no point fixing it now, so let's remove it. > > Signed-off-by: Arnd Bergmann > --- > There has been some discussion about removing all the ISA based ISDN > drivers in the past. I'm not trying to restart that discussion at the > moment, and I did not find the same bug in the other drivers, so > let's just remove this one for now. Applied to net-next, we can resurrect+fix this driver if someone actually uses it. Thanks Arnd.