From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757492AbbLBCyQ (ORCPT ); Tue, 1 Dec 2015 21:54:16 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:34655 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752325AbbLBCyP (ORCPT ); Tue, 1 Dec 2015 21:54:15 -0500 Date: Tue, 01 Dec 2015 21:54:10 -0500 (EST) Message-Id: <20151201.215410.1740396521919421561.davem@davemloft.net> To: kys@microsoft.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com Subject: Re: [PATCH net-next V3 00/17] hv_netvsc: Eliminate the additional head room From: David Miller In-Reply-To: <1449016978-9755-1-git-send-email-kys@microsoft.com> References: <1449016978-9755-1-git-send-email-kys@microsoft.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Dec 2015 18:54:15 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "K. Y. Srinivasan" Date: Tue, 1 Dec 2015 16:42:58 -0800 > In an attempt to avoid having to allocate memory on the send path, the netvsc > driver was requesting additional head room so that both rndis header and the > netvsc packet (the state that had to persist) could be placed in the skb. > Since the amount of head room requested was exceeding the default head room > as set in LL_MAX_HEADER, we were forcing a reallocation of skb. > > With this patch-set, I have reduced the size of the netvsc packet to less > than 20 bytes and with this reduction we don't need to ask for any additional > headroom. We place the rndis header in the skb head room and we place the > netvsc packet in control buffer area in the skb. > > V2: - Addressed review comments: > - Eliminated more fields from netvsc packet structure. > > V3: - Fixed a typo in patch: hv_netvsc: Don't ask for additional head room in the skb. Series applied, thanks.