From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757197AbbLAXiO (ORCPT ); Tue, 1 Dec 2015 18:38:14 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58475 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755735AbbLAXiN (ORCPT ); Tue, 1 Dec 2015 18:38:13 -0500 Date: Tue, 1 Dec 2015 15:38:12 -0800 From: Andrew Morton To: Rasmus Villemoes Cc: Tejun Heo , Joe Perches , linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/13] lib/vsprintf.c: expand field_width to 24 bits Message-Id: <20151201153812.8312aae7ff2b9b20d3fe6c4e@linux-foundation.org> In-Reply-To: <1445373013-20207-5-git-send-email-linux@rasmusvillemoes.dk> References: <1445373013-20207-1-git-send-email-linux@rasmusvillemoes.dk> <1445373013-20207-5-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Oct 2015 22:30:04 +0200 Rasmus Villemoes wrote: > I didn't find a BUILD_BUG/compiletime_assertion/... which would work > outside function context, so for now I just open-coded it. > It comes up occasionally. It would be better to create one. > +extern char __check_printf_spec[1-2*(sizeof(struct printf_spec) != 8)]; Maybe something like /* * Description goes here */ #define BUILD_BUG_ON_STATIC(unique_id, expr) \ typedef char unique_id[1-2*(expr)]; BUILD_BUG_ON_STATIC(__check_printf_spec, sizeof(struct printf_spec) != 8); ("static" seems the wrong term, but what is the correct term for "outside of functions"?) (I hope this patchset is still up-to-date)