From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756570AbbLAOnL (ORCPT ); Tue, 1 Dec 2015 09:43:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34174 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755608AbbLAOnJ (ORCPT ); Tue, 1 Dec 2015 09:43:09 -0500 Date: Tue, 1 Dec 2015 16:43:05 +0200 From: "Michael S. Tsirkin" To: Jason Wang Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 3/3] vhost_net: basic polling support Message-ID: <20151201163939-mutt-send-email-mst@redhat.com> References: <1448435489-5949-1-git-send-email-jasowang@redhat.com> <1448435489-5949-4-git-send-email-jasowang@redhat.com> <20151130124233-mutt-send-email-mst@redhat.com> <565D2D7D.4010903@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <565D2D7D.4010903@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 01, 2015 at 01:17:49PM +0800, Jason Wang wrote: > > > On 11/30/2015 06:44 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 25, 2015 at 03:11:29PM +0800, Jason Wang wrote: > >> > This patch tries to poll for new added tx buffer or socket receive > >> > queue for a while at the end of tx/rx processing. The maximum time > >> > spent on polling were specified through a new kind of vring ioctl. > >> > > >> > Signed-off-by: Jason Wang > > One further enhancement would be to actually poll > > the underlying device. This should be reasonably > > straight-forward with macvtap (especially in the > > passthrough mode). > > > > > > Yes, it is. I have some patches to do this by replacing > skb_queue_empty() with sk_busy_loop() but for tap. We probably don't want to do this unconditionally, though. > Tests does not show > any improvement but some regression. Did you add code to call sk_mark_napi_id on tap then? sk_busy_loop won't do anything useful without. > Maybe it's better to test macvtap. Same thing ... -- MST