From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756028AbbLAQxL (ORCPT ); Tue, 1 Dec 2015 11:53:11 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56321 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754368AbbLAQxK (ORCPT ); Tue, 1 Dec 2015 11:53:10 -0500 Date: Tue, 1 Dec 2015 16:53:01 +0000 From: Mark Brown To: Arnd Bergmann Cc: Thierry Reding , linux-kernel@vger.kernel.org, Tyler Baker Message-ID: <20151201165301.GM1929@sirena.org.uk> References: <1448988057-13965-1-git-send-email-broonie@kernel.org> <1503180.zM1PdPxpk1@wuerfel> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hsRx9nTMbkea5ZWm" Content-Disposition: inline In-Reply-To: <1503180.zM1PdPxpk1@wuerfel> X-Cookie: A beer delayed is a beer denied. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: core: Ensure we lock all regulators X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hsRx9nTMbkea5ZWm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 01, 2015 at 05:45:17PM +0100, Arnd Bergmann wrote: > On Tuesday 01 December 2015 16:40:57 Mark Brown wrote: > > mutex_lock(&rdev->mutex); > > - for (i = 1; rdev->supply; rdev = rdev->supply->rdev, i++) > > + for (i = 1; rdev; rdev = rdev->supply->rdev, i++) > > mutex_lock_nested(&rdev->mutex, i); > I think now we have a double lock, the initial mutex_lock() needs to > be removed again. Ugh, I even made that fix before I sent but didn't actually commit it :( --hsRx9nTMbkea5ZWm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWXdBsAAoJECTWi3JdVIfQ+3YH/18fDV8Cn93rVXMjP9OLDks7 jcpB0z4CcQVZcytWnOHF6bzNT52n7dEi1niKXyCmnzHeJDd0r2br0fV6hqSFGgzc iOp5yMPXCdpnHJvT3UkggaDLEPYjEt7ktG6mKGp/OLOu4fmEVDrKnemQzqkRCsr+ bKcMmiiucUDDguIg/S3+TwmnXbKi9gUwRhBiMZ6Lk/MdV62Yt2Ns8lvgkuUD2oqF Zl3jUFD5VdTqik8Zs3JdmsSu2VwRopU4H8xeqVbBHmQdY/+wdHaVQmA7xLa4hW8N vNW3NXiU3P+QPTMB6QbHXRjpEjRpq9md87bzi+UJSiIqaOQflw3Pi60cPtAiQVI= =tsmQ -----END PGP SIGNATURE----- --hsRx9nTMbkea5ZWm--