From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756680AbbLASAY (ORCPT ); Tue, 1 Dec 2015 13:00:24 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56379 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756204AbbLASAV (ORCPT ); Tue, 1 Dec 2015 13:00:21 -0500 Date: Tue, 1 Dec 2015 17:59:56 +0000 From: Mark Brown To: Damien Horsley Cc: alsa-devel@alsa-project.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Jyri Sarha , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, James Hartley Message-ID: <20151201175956.GN1929@sirena.org.uk> References: <1448376224-23964-3-git-send-email-Damien.Horsley@imgtec.com> <20151127125411.GR1929@sirena.org.uk> <565C7E1A.1000104@imgtec.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="59V5pGBotOHHLP27" Content-Disposition: inline In-Reply-To: <565C7E1A.1000104@imgtec.com> X-Cookie: A beer delayed is a beer denied. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: pcm3168a: Add driver for pcm3168a codec X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --59V5pGBotOHHLP27 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 30, 2015 at 04:49:30PM +0000, Damien Horsley wrote: > On 27/11/15 12:54, Mark Brown wrote: > > Please try to keep your CC lists reasonable - only CC people who have an > > interest in the patch you're posting. The CC list you have here is far > > too broad, I can't figure out why a lot of the people there ended up > > there. If you've got 10 people that's generally a warning sign. > The list was generated by scripts/get_maintainer.pl when used on the > patches. I will remove some that look like they don't need to be there. You should not be using get_maintainer unfiltered, you need to think about why everyone is there. People often end up getting included due to just random cleanups and getting lots of mail about drivers they have no lasting interest in may be demotivating. > > Being in right justified mode *does* have an effect - it changes where > > the audio data starts relative to LRCLK. It is true that if the frame > > has exactly the right number of clocks left and right justified are > > identical but extra clocks are in general permitted so it looks like > > your right justified case above just isn't something the device really > > supports. > Should the value returned by snd_soc_params_to_frame_size be treated as > the minimum frame size? Yes, in general most hardware is perfectly happy with extra clocks. --59V5pGBotOHHLP27 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWXeAbAAoJECTWi3JdVIfQrKAH/iqPyMv/FL4E2kmuN6Lvg6oY HkH/vdONjMFUPZU9FZp2kRPOZoLbVfVw7FwuTp1871nklCXR1YgKbQT4TXPJGpZJ VO8Mf0b8bUkuJxwKe1BZ8rKMdd/rhGdrCe4TFqjCjBVNKmBww3N2ftbu7rtGiUL7 mZMErqUWX5sm2GzzbxByrVsLD9IpkgGnPz6jeCyVfu6XAQfrJnrrWFktGSL4vXc2 PF7DBMA2eRO9l5vdQi8p6hJT9lTgF2aKqK8W7u8t+gNgAT5D+THDEmYAPB/UgEHX 3Q0UQPWNOMLky1IK4NcyZdty5SsVsUKr8Pub5xMESb9qeuEGFeEhE6SGxan7W4o= =Wget -----END PGP SIGNATURE----- --59V5pGBotOHHLP27--