Re: [PATCH 2/2] usb: pci-quirks: register USB mux found on Cherrytrail SOC

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

Hi,

> > @@ -1029,9 +1030,36 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
> >  	writel(val, base + ext_cap_offset + XHCI_LEGACY_CONTROL_OFFSET);
> >  
> >  hc_init:
> > -	if (pdev->vendor == PCI_VENDOR_ID_INTEL)
> > +	if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
> >  		usb_enable_intel_xhci_ports(pdev);
> >  
> > +		/*
> > +		 * Initialize the internal mux that shares a port between USB
> > +		 * Device Controller and xHCI on platforms that have it.
> > +		 */
> > +#define XHCI_INTEL_VENDOR_CAPS 192
> > +#define XHCI_INTEL_USB_MUX_OFFSET 0x80d8
> > +		ext_cap_offset = xhci_find_next_cap_offset(base,
> > +							XHCI_HCC_PARAMS_OFFSET);
> > +		ext_cap_offset = xhci_find_ext_cap_by_id(base, ext_cap_offset,
> > +							XHCI_INTEL_VENDOR_CAPS);
> 
> Hi Heikki,
> 
> This helper has been replaced with xhci_find_next_ext_cap() in
> commit d5ddcdf(xhci: rework xhci extended capability list parsing functions).
> 
> Need to fix this, otherwise it will not pass compile on top of usb-next.

Thanks Baolu. I'll fix it.


Cheers,

-- 
heikki