From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932522AbbLBPDv (ORCPT ); Wed, 2 Dec 2015 10:03:51 -0500 Received: from smtprelay0124.hostedemail.com ([216.40.44.124]:54354 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932335AbbLBPDt (ORCPT ); Wed, 2 Dec 2015 10:03:49 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3353:3622:3865:3867:3870:3872:3873:5007:6261:7875:7903:9012:9038:9389:10004:10394:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12663:12740:13069:13311:13357:14096:14097:14659:21080:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: cloth39_5b58a91a1ba0e X-Filterd-Recvd-Size: 2610 Date: Wed, 2 Dec 2015 10:03:46 -0500 From: Steven Rostedt To: Jiri Olsa Cc: LKML , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH] ftrace: Remove use of control list and ops Message-ID: <20151202100346.3fa57158@gandalf.local.home> In-Reply-To: <20151202145032.GA5255@krava.brq.redhat.com> References: <20151130173640.2c45b429@gandalf.local.home> <20151201134213.GA14155@krava.brq.redhat.com> <20151201095554.7b56bff7@gandalf.local.home> <20151201155744.GA24786@krava.local> <20151201115655.1b7e79e6@gandalf.local.home> <20151202085826.GA1068@krava.brq.redhat.com> <20151202092700.7021eda8@gandalf.local.home> <20151202145032.GA5255@krava.brq.redhat.com> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Dec 2015 15:50:32 +0100 Jiri Olsa wrote: > On Wed, Dec 02, 2015 at 09:27:00AM -0500, Steven Rostedt wrote: > > On Wed, 2 Dec 2015 09:58:26 +0100 > > Jiri Olsa wrote: > > > > > On Tue, Dec 01, 2015 at 11:56:55AM -0500, Steven Rostedt wrote: > > > > > > SNIP > > > > > > > -static void ftrace_ops_recurs_func(unsigned long ip, unsigned long parent_ip, > > > > +static void ftrace_ops_assist_func(unsigned long ip, unsigned long parent_ip, > > > > struct ftrace_ops *op, struct pt_regs *regs) > > > > { > > > > int bit; > > > > > > > > + if ((op->flags & FTRACE_OPS_FL_RCU) && !rcu_is_watching()) > > > > + return; > > > > + > > > > bit = trace_test_and_set_recursion(TRACE_LIST_START, TRACE_LIST_MAX); > > > > if (bit < 0) > > > > return; > > > > > > > > - op->func(ip, parent_ip, op, regs); > > > > + preempt_disable_notrace(); > > > > > > > > + if (!(op->flags & FTRACE_OPS_FL_PER_CPU) || > > > > + ftrace_function_local_disabled(op)) { > > > > > > should be !ftrace_function_local_disabled(op) in here, > > > I passed my test with attached patch > > > > > > > Can you retest with this patch: > > sure, but other than the declaration removal it's the same change > Yep, but I'm paranoid :-) Any change I like to get retested. But if you're fine, can I get a 'Tested-by' from you? -- Steve