From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933068AbbLBQcf (ORCPT ); Wed, 2 Dec 2015 11:32:35 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:38505 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932666AbbLBQca (ORCPT ); Wed, 2 Dec 2015 11:32:30 -0500 Date: Wed, 2 Dec 2015 17:32:27 +0100 From: Michal Hocko To: Geliang Tang Cc: Andrew Morton , Vlastimil Babka , Mel Gorman , David Rientjes , Joonsoo Kim , "Kirill A. Shutemov" , Johannes Weiner , Alexander Duyck , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm/page_alloc.c: use list_for_each_entry in mark_free_pages() Message-ID: <20151202163227.GL25284@dhcp22.suse.cz> References: <7009a8fa2dba33da9bcfe60db4741139c07c8074.1449068845.git.geliangtang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7009a8fa2dba33da9bcfe60db4741139c07c8074.1449068845.git.geliangtang@163.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 02-12-15 23:12:41, Geliang Tang wrote: > Use list_for_each_entry instead of list_for_each + list_entry to > simplify the code. > > Signed-off-by: Geliang Tang Acked-by: Michal Hocko > --- > mm/page_alloc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 0d38185..1c1ad58 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2027,7 +2027,7 @@ void mark_free_pages(struct zone *zone) > unsigned long pfn, max_zone_pfn; > unsigned long flags; > unsigned int order, t; > - struct list_head *curr; > + struct page *page; > > if (zone_is_empty(zone)) > return; > @@ -2037,17 +2037,17 @@ void mark_free_pages(struct zone *zone) > max_zone_pfn = zone_end_pfn(zone); > for (pfn = zone->zone_start_pfn; pfn < max_zone_pfn; pfn++) > if (pfn_valid(pfn)) { > - struct page *page = pfn_to_page(pfn); > - > + page = pfn_to_page(pfn); > if (!swsusp_page_is_forbidden(page)) > swsusp_unset_page_free(page); > } > > for_each_migratetype_order(order, t) { > - list_for_each(curr, &zone->free_area[order].free_list[t]) { > + list_for_each_entry(page, > + &zone->free_area[order].free_list[t], lru) { > unsigned long i; > > - pfn = page_to_pfn(list_entry(curr, struct page, lru)); > + pfn = page_to_pfn(page); > for (i = 0; i < (1UL << order); i++) > swsusp_set_page_free(pfn_to_page(pfn + i)); > } > -- > 2.5.0 > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Michal Hocko SUSE Labs