From: Mike Krinkin <krinkin.m.u@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
kent.overstreet@gmail.com, dmonakhov@openvz.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: add calls to split trace point
Date: Wed, 2 Dec 2015 22:09:18 +0300 [thread overview]
Message-ID: <20151202190918.GA4325@kmu-tp-x230> (raw)
In-Reply-To: <565F2501.40301@kernel.dk>
On Wed, Dec 02, 2015 at 10:06:09AM -0700, Jens Axboe wrote:
> On 12/02/2015 01:25 AM, Mike Krinkin wrote:
> >Hi Jens,
> >
> >i would like to check status of the patch, will the patch be applied?
> >
>
> Why aren't you just putting the split trace call into blk_queue_split()?
Do you mean after split? Something like this:
if (split) {
/* there isn't chance to merge the splitted bio */
split->bi_rw |= REQ_NOMERGE;
bio_chain(split, *bio);
trace_block_split(q, split, bio->bi_iter.bi_sector);
generic_make_request(*bio);
*bio = split;
}
block_split trace event docs says that it expects "bio being split", i
understood it as "bio before split". But scarcely someone depends on
this behaviour, so i'll resend the patch, is it ok?
next prev parent reply other threads:[~2015-12-02 19:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 18:53 Mike Krinkin
2015-11-18 14:01 ` Christoph Hellwig
2015-12-02 8:25 ` Mike Krinkin
2015-12-02 17:06 ` Jens Axboe
2015-12-02 19:09 ` Mike Krinkin [this message]
2015-12-03 14:32 ` [PATCH] block: add call " Mike Krinkin
2015-12-03 17:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202190918.GA4325@kmu-tp-x230 \
--to=krinkin.m.u@gmail.com \
--cc=axboe@kernel.dk \
--cc=dmonakhov@openvz.org \
--cc=hch@lst.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®