From: Alasdair G Kergon <agk@redhat.com>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Mark Brown <broonie@kernel.org>, Jens Axboe <axboe@kernel.dk>,
keith.busch@intel.com, Jan Kara <jack@suse.cz>,
Arnd Bergmann <arnd@arndb.de>, Mike Snitzer <snitzer@redhat.com>,
neilb@suse.com, LKML <linux-kernel@vger.kernel.org>,
linux-raid@vger.kernel.org, dm-devel@redhat.com, "Garg,
Dinesh" <dineshg@quicinc.com>,
tj@kernel.org, bart.vanassche@sandisk.com, jmoyer@redhat.com,
Alasdair G Kergon <agk@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>
Subject: Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt
Date: Wed, 2 Dec 2015 19:56:57 +0000 [thread overview]
Message-ID: <20151202195657.GB11127@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <CAMz4kuLTuY5CpTfW4Gijesy1Pp9PxbWj076XeoV24Hj3EydifQ@mail.gmail.com>
On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote:
> These are the benchmarks for request based dm-crypt. Please check it.
Now please put request-based dm-crypt completely to one side and focus
just on the existing bio-based code. Why is it slower and what can be
adjusted to improve this?
People aren't going to take a request-based solution seriously until
you can explain in full detail *why* bio-based is slower AND why it's
impossible to improve its performance.
> For request based things, some sequential bios/requests can merged
> into one request to expand the IO size to be a big block handled by
> hardware engine at one time.
Bio-based also merges I/O so that does not provide justification.
Investigate in much more detail the actual merging and scheduling
involved in the cases you need to optimise. See if blktrace gives you
any clues, or add your own instrumentation. You could even look at some
of the patches we've had in the list archives for optimising bio-based
crypt in different situations.
Alasdair
next prev parent reply other threads:[~2015-12-02 19:57 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 9:31 Baolin Wang
2015-11-11 9:31 ` [PATCH 1/2] block: Introduce BIO_ENDIO_FREE for bio flags Baolin Wang
2015-11-11 17:54 ` Mike Snitzer
2015-11-12 4:05 ` Baolin Wang
2015-11-11 9:31 ` [PATCH 2/2] md: dm-crypt: Introduce the request handling for dm-crypt Baolin Wang
2015-11-11 9:48 ` [PATCH 0/2] " Christoph Hellwig
2015-11-12 2:15 ` Baolin Wang
2015-11-12 9:17 ` Jan Kara
2015-11-12 9:40 ` Baolin Wang
2015-11-12 11:06 ` Jan Kara
2015-11-12 11:46 ` Baolin Wang
2015-11-12 12:24 ` Jan Kara
2015-11-12 12:51 ` Baolin Wang
2015-11-12 12:57 ` Arnd Bergmann
2015-11-12 15:02 ` Mark Brown
2015-11-13 3:27 ` Baolin Wang
2015-11-13 3:25 ` Baolin Wang
2015-11-12 12:59 ` Jan Kara
2015-11-13 2:05 ` Baolin Wang
2015-11-13 9:05 ` Arnd Bergmann
2015-11-13 11:37 ` Baolin Wang
2015-11-11 18:18 ` Mike Snitzer
2015-11-12 2:36 ` Baolin Wang
2015-11-12 9:06 ` [dm-devel] " Christoph Hellwig
2015-11-12 8:20 ` Baolin Wang
2015-11-12 10:04 ` Mark Brown
2015-11-12 15:26 ` Jens Axboe
2015-11-13 2:07 ` Baolin Wang
2015-11-13 11:51 ` Mark Brown
2015-12-02 12:46 ` Baolin Wang
2015-12-02 19:56 ` Alasdair G Kergon [this message]
2015-12-03 2:56 ` [dm-devel] " Baolin Wang
2015-12-03 10:36 ` Baolin Wang
2015-12-03 11:07 ` Zdenek Kabelac
2015-12-03 11:27 ` Baolin Wang
2015-12-03 15:49 ` Mikulas Patocka
2015-12-04 4:58 ` Baolin Wang
2015-12-03 15:47 ` Mikulas Patocka
2015-12-04 4:57 ` Baolin Wang
2015-11-12 9:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202195657.GB11127@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=baolin.wang@linaro.org \
--cc=bart.vanassche@sandisk.com \
--cc=broonie@kernel.org \
--cc=dineshg@quicinc.com \
--cc=dm-devel@redhat.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=neilb@suse.com \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®