From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759648AbbLCNRY (ORCPT ); Thu, 3 Dec 2015 08:17:24 -0500 Received: from mail-pa0-f67.google.com ([209.85.220.67]:35133 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbbLCNRX (ORCPT ); Thu, 3 Dec 2015 08:17:23 -0500 Date: Thu, 3 Dec 2015 21:16:48 +0800 From: Boqun Feng To: Peter Zijlstra Cc: mingo@kernel.org, oleg@redhat.com, linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com, corbet@lwn.net, mhocko@kernel.org, dhowells@redhat.com, torvalds@linux-foundation.org, will.deacon@arm.com, waiman.long@hpe.com, pjt@google.com Subject: Re: [PATCH 4/4] sched: Document Program-Order guarantees Message-ID: <20151203131648.GA2460@fixme-laptop> References: <20151203124010.627312076@infradead.org> <20151203124339.665446482@infradead.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline In-Reply-To: <20151203124339.665446482@infradead.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 03, 2015 at 01:40:14PM +0100, Peter Zijlstra wrote: [snip] > + * > + * CPU0 (schedule) CPU1 (try_to_wake_up) CPU2 (schedule) > + * > + * LOCK rq(0)->lock LOCK X->pi_lock > + * dequeue X > + * sched-out X > + * smp_store_release(X->on_cpu, 0); > + * > + * smp_cond_acquire(!X->on_cpu); > + * X->state = WAKING > + * set_task_cpu(X,2) > + * > + * LOCK rq(2)->lock > + * enqueue X > + * X->state = RUNNING > + * UNLOCK rq(2)->lock > + * > + * LOCK rq(2)->lock // orders against CPU1 > + * sched-out Z > + * sched-in X > + * UNLOCK rq(1)->lock ^^^^^^^^^^^^^^^ This is a typo, right? Should be "UNLOCK rq(2)->lock". Regards, Boqun > + * > + * UNLOCK X->pi_lock > + * UNLOCK rq(0)->lock > + * > + * --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJWYEC8AAoJEEl56MO1B/q4JP8H/ia0Kv626NckMaDcGfyqrtlr luZ8pbwd41XUNHBkKa+gjhXtt33LjnxwvakVPBnFycyJPUaMirFJneFOXj3Ao/rx OnqbMSoyjQtWy5A6zJNpNudJ1cf3+AqEKe05yi7NeSLyUCLVghsq9iYiDzV26eG3 uFhnzvWT8bkGuzHGiR2OGMfZeef8vHuV2BVTerHCIaCNssgMqJorselm4/hCbmaG jg8vF39zbBDW9aDk7vfvoEu/tm4+vb+FGKAr2Hl1+GB5Ri8fluVkeAFczhZ1+148 /6tPW/VrKHfv6SwvHpCS/cpqRZmFx5sVRUU483Zrqly4EkBe3DrIYPH2dTOneZQ= =JWYD -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd--