From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm_crb: Use the common ACPI definition of struct acpi_tpm2
Date: Thu, 3 Dec 2015 10:02:17 -0700 [thread overview]
Message-ID: <20151203170217.GB32175@obsidianresearch.com> (raw)
In-Reply-To: <20151203082753.GA18043@intel.com>
On Thu, Dec 03, 2015 at 10:27:53AM +0200, Jarkko Sakkinen wrote:
> On Wed, Dec 02, 2015 at 12:19:00PM -0700, Jason Gunthorpe wrote:
> > include/acpi/actbl2.h is the proper place for these definitions
> > and the needed TPM2 ones have been there since
> > commit 413d4a6defe0 ("ACPICA: Update TPM2 ACPI table")
> >
> > This also drops the le32_to_cpu for members of this table,
> > consistent with other ACPI stuff.
>
> Why le32_to_cpu() is not needed?
Why is it needed?
None of the fields are marked le32 in the struct and no other ACPI
thing I could find swaps.
If swapping is needed then the struct fields must be declared as 'le'
Jason
next prev parent reply other threads:[~2015-12-03 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 19:19 Jason Gunthorpe
2015-12-03 8:27 ` Jarkko Sakkinen
2015-12-03 17:02 ` Jason Gunthorpe [this message]
2015-12-06 1:25 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203170217.GB32175@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®