From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932271AbbLEBDU (ORCPT ); Fri, 4 Dec 2015 20:03:20 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48958 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932107AbbLEBDT (ORCPT ); Fri, 4 Dec 2015 20:03:19 -0500 Date: Fri, 4 Dec 2015 17:03:17 -0800 From: Andrew Morton To: Michal Hocko Cc: Johannes Weiner , Vladimir Davydov , Hugh Dickins , linux-mm@kvack.org, LKML Subject: Re: [PATCH] memcg, vmscan: Do not wait for writeback if killed Message-Id: <20151204170317.4bb1347cce4d4b3e03a18e1e@linux-foundation.org> In-Reply-To: <20151203090826.GD9264@dhcp22.suse.cz> References: <1449066378-4764-1-git-send-email-mhocko@kernel.org> <20151202142503.0921c0d6e06394ff7dff85fa@linux-foundation.org> <20151203090826.GD9264@dhcp22.suse.cz> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Dec 2015 10:08:26 +0100 Michal Hocko wrote: > So you think a comment would be sufficient? > --- > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 98a1934493af..2e8ee9e5fcb5 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1031,9 +1031,12 @@ static unsigned long shrink_page_list(struct list_head *page_list, > /* > * We've got killed while waiting here so > * expedite our way out from the reclaim > + * > + * Our callers should make sure we do not > + * get here with fatal signals again. > */ Seems OK. s/should/must/ Please resend it all after the usual exhaustive testing ;)