From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753039AbbLEWYo (ORCPT ); Sat, 5 Dec 2015 17:24:44 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:39233 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751915AbbLEWYn (ORCPT ); Sat, 5 Dec 2015 17:24:43 -0500 Date: Sat, 05 Dec 2015 17:24:37 -0500 (EST) Message-Id: <20151205.172437.1660871557891874317.davem@davemloft.net> To: mw@semihalf.com Cc: gregory.clement@free-electrons.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, thomas.petazzoni@free-electrons.com, jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, ezequiel.garcia@free-electrons.com, linux-arm-kernel@lists.infradead.org, alior@marvell.com, nadavh@marvell.com, simon.guinot@sequanux.org, maxime.ripard@free-electrons.com, boris.brezillon@free-electrons.com, linux@arm.linux.org.uk, w@1wt.eu, arnd@arndb.de Subject: Re: [PATCH net-next v2 4/4] net: mvneta: Spread out the TX queues management on all CPUs From: David Miller In-Reply-To: References: <1449254700-32685-1-git-send-email-gregory.clement@free-electrons.com> <1449254700-32685-5-git-send-email-gregory.clement@free-electrons.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 05 Dec 2015 14:24:42 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marcin Wojtas Date: Sat, 5 Dec 2015 20:14:31 +0100 > Hi Gregory, > >> @@ -1824,13 +1835,16 @@ error: >> static int mvneta_tx(struct sk_buff *skb, struct net_device *dev) >> { >> struct mvneta_port *pp = netdev_priv(dev); >> - u16 txq_id = skb_get_queue_mapping(skb); >> + u16 txq_id = smp_processor_id() % txq_number; > > I think it may be ok to bind TXQs to different CPUs, but I don't think > that replacing skb_get_queue_mapping by in fact smp_processor_id() is > the best idea. This way you use only 2 TXQs on A385 and 4 TXQs on AXP. > There are HW mechanisms like WRR or EJP that provide balancing for > egress, so let's better keep all 8. Also it is possible for other parts of the stack to set the SKB queue mapping and you must respect that setting rather than override it.