From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754120AbbLFEM7 (ORCPT ); Sat, 5 Dec 2015 23:12:59 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:44761 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752954AbbLFEM6 (ORCPT ); Sat, 5 Dec 2015 23:12:58 -0500 Date: Sat, 05 Dec 2015 23:12:53 -0500 (EST) Message-Id: <20151205.231253.1057553137456534699.davem@davemloft.net> To: sowmini.varadhan@oracle.com Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com, shannon.nelson@intel.com, carolyn.wyborny@intel.com, donald.c.skidmore@intel.com, matthew.vick@intel.com, john.ronciak@intel.com, mitch.a.williams@intel.com, andy.shevchenko@gmail.com Subject: Re: [PATCH v8] i40e: Look up MAC address in Open Firmware or IDPROM From: David Miller In-Reply-To: <20151205203300.GA8863@oracle.com> References: <20151205203300.GA8863@oracle.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 05 Dec 2015 20:12:57 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sowmini Varadhan Date: Sat, 5 Dec 2015 15:33:00 -0500 > +static void i40e_get_platform_mac_addr(struct pci_dev *pdev, struct i40e_pf *pf) > +{ > + struct device_node *dp = pci_device_to_OF_node(pdev); > + const unsigned char *addr; > + u8 *mac_addr = pf->hw.mac.addr; > + > + pf->flags &= ~I40E_FLAG_PF_MAC; > + addr = of_get_mac_address(dp); > + if (addr) { > + ether_addr_copy(mac_addr, addr); > + pf->flags |= I40E_FLAG_PF_MAC; > + } > +#ifdef CONFIG_SPARC > + ether_addr_copy(mac_addr, idprom->id_ethaddr); > + pf->flags |= I40E_FLAG_PF_MAC; > +#endif /* CONFIG_SPARC */ > +} This logic doesn't look right. If we find an address via of_get_mac_address() we should not use the IDPROM address. But here you are, since the IDPROM code runs unconditionally.