From: Andrew Lunn <andrew@lunn.ch>
To: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: Gregory Clement <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH/RESEND] ARM: dts: kirkwood: Add DTS for Zyxel NSA325
Date: Mon, 7 Dec 2015 02:41:10 +0100 [thread overview]
Message-ID: <20151207014110.GB19715@lunn.ch> (raw)
In-Reply-To: <1449334057-6008-1-git-send-email-ulli.kroll@googlemail.com>
> + serial@12000 {
> + status = "ok";
> + };
> +
> + sata@80000 {
> + status = "okay";
> + nr-ports = <2>;
> + };
> + };
> +
> + gpio-leds {
> + compatible = "gpio-leds";
> + pinctrl-0 = <&pmx_led_hdd2_green &pmx_led_hdd2_red
> + &pmx_led_usb_green
> + &pmx_led_sys_green &pmx_led_sys_orange
> + &pmx_led_copy_green &pmx_led_copy_red
> + &pmx_led_hdd1_green &pmx_led_hdd1_red>;
> + pinctrl-names = "default";
Hi Hans
There is some odd indentation going on here, and in other parts of the
file.
> +
> +&nand {
> + status = "okay";
> + chip-delay = <35>;
> +
> + partition@0 {
> + label = "uboot";
> + reg = <0x0000000 0x0100000>;
> + };
The partitions should be inside a partitions node. See
Documentation/devicetree/bindings/mtd/partition.txt
prev parent reply other threads:[~2015-12-07 1:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-05 16:47 Hans Ulli Kroll
2015-12-07 1:41 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207014110.GB19715@lunn.ch \
--to=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®