From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755674AbbLGGHj (ORCPT ); Mon, 7 Dec 2015 01:07:39 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33593 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755580AbbLGGHh (ORCPT ); Mon, 7 Dec 2015 01:07:37 -0500 Date: Mon, 7 Dec 2015 11:37:31 +0530 From: Sudip Mukherjee To: Sanidhya Solanki Cc: kbuild test robot , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header Message-ID: <20151207060731.GB4122@sudip-pc> References: <20151205063529.780bf436@gmail.com> <201512060035.GGCfWsZs%fengguang.wu@intel.com> <20151205222516.13a8baf6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151205222516.13a8baf6@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 05, 2015 at 10:25:16PM -0500, Sanidhya Solanki wrote: > I disagree with the output of the automaton. Included below are my > compile checks before and after the patch. Build fails with: skein_block.c: multiple definition of 'skein_256_process_block' And you moved skein_256_process_block() from skein_block.c to a header file. Is skein_256_process_block() a macro? regards sudip