From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754981AbbLGJcm (ORCPT ); Mon, 7 Dec 2015 04:32:42 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:57229 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753633AbbLGJcl (ORCPT ); Mon, 7 Dec 2015 04:32:41 -0500 Date: Mon, 7 Dec 2015 10:32:36 +0100 From: Sascha Hauer To: Anton Bondarenko Cc: broonie@kernel.org, b38343@freescale.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vladimir_zapolskiy@mentor.com, jiada_wang@mentor.com Subject: Re: [PATCH v5 06/11] spi: imx: return error from dma channel request Message-ID: <20151207093236.GB11966@pengutronix.de> References: <1449334629-4715-1-git-send-email-anton.bondarenko.sama@gmail.com> <1449334629-4715-7-git-send-email-anton.bondarenko.sama@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449334629-4715-7-git-send-email-anton.bondarenko.sama@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:30:35 up 50 days, 18:09, 97 users, load average: 0.24, 0.44, 0.38 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 05, 2015 at 05:57:04PM +0100, Anton Bondarenko wrote: > On SDMA initialization return exactly the same error, which is > reported by dma_request_slave_channel_reason(), it is a preceding > change to defer SPI DMA initialization, if SDMA module is not yet > available. > > Signed-off-by: Vladimir Zapolskiy > Signed-off-by: Anton Bondarenko > --- > drivers/spi/spi-imx.c | 27 ++++++++++++++++----------- > 1 file changed, 16 insertions(+), 11 deletions(-) > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c > index 3525616..277dd75 100644 > --- a/drivers/spi/spi-imx.c > +++ b/drivers/spi/spi-imx.c > @@ -846,10 +846,11 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx, > spi_imx->wml = spi_imx_get_fifosize(spi_imx) / 2; > > /* Prepare for TX DMA: */ > - master->dma_tx = dma_request_slave_channel(dev, "tx"); > - if (!master->dma_tx) { > - dev_err(dev, "cannot get the TX DMA channel!\n"); > - ret = -EINVAL; > + master->dma_tx = dma_request_slave_channel_reason(dev, "tx"); > + if (IS_ERR(master->dma_tx)) { > + dev_info(dev, "cannot get the TX DMA channel!\n"); When changing it can you add the error code to the message? That's usually the next thing one wants to know when reading it. Also, isn't dev_dbg enough here? Otherwise the driver gets really verbose when it actually defers probe. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |