From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751416AbbLHRN7 (ORCPT ); Tue, 8 Dec 2015 12:13:59 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:38260 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbbLHRN6 (ORCPT ); Tue, 8 Dec 2015 12:13:58 -0500 Date: Tue, 08 Dec 2015 12:13:56 -0500 (EST) Message-Id: <20151208.121356.1131159668858222040.davem@davemloft.net> To: mst@redhat.com Cc: arnd@arndb.de, netdev@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, asias@redhat.com, stefanha@redhat.com Subject: Re: [PATCH] vhost: vsock: select CONFIG_VHOST From: David Miller In-Reply-To: <20151208180529-mutt-send-email-mst@redhat.com> References: <36261336.7BBY96nNaM@wuerfel> <20151208180529-mutt-send-email-mst@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 08 Dec 2015 09:13:58 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Michael S. Tsirkin" Date: Tue, 8 Dec 2015 18:09:44 +0200 > On Tue, Dec 08, 2015 at 04:46:08PM +0100, Arnd Bergmann wrote: >> When building the new vsock code without vhost, we get a build error: >> >> drivers/built-in.o: In function `vhost_vsock_flush': >> :(.text+0x24d29c): undefined reference to `vhost_poll_flush' >> >> This adds an explicit 'select' like we have for the other vhost >> drivers. >> >> Signed-off-by: Arnd Bergmann > > This will need to be done eventually, so > > Acked-by: Michael S. Tsirkin > > but I really think the right thing for now is to revert current vsock > code, or disable building it unconditionally. Stefan, could you please > send a patch like this? I'm waiting for the full single revert patch and will apply it as soon as I receive it.