From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Radivoje Jovanovic <radivoje.jovanovic@intel.com>,
Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>,
Mathias Krause <minipli@googlemail.com>,
Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH] powercap, intel_rapl.c, fix BIOS lock check
Date: Tue, 8 Dec 2015 15:30:16 -0800 [thread overview]
Message-ID: <20151208153016.0dcebee1@icelake> (raw)
In-Reply-To: <1449599602-4512-1-git-send-email-prarit@redhat.com>
On Tue, 8 Dec 2015 13:33:22 -0500
Prarit Bhargava <prarit@redhat.com> wrote:
> Intel RAPL initialized on several systems where the BIOS lock bit (msr
> 0x610, bit 63) was set. This occured because the return value of
> rapl_read_data_raw() was being checked, rather than the value of the
> variable passed in, locked.
>
> This patch properly implments the rapl_read_data_raw() call to check
> the variable locked, and now the Intel RAPL driver outputs the
> warning:
>
> intel_rapl: RAPL package 0 domain package locked by BIOS
>
> and does not initialize for the package.
Looks good to me.
next prev parent reply other threads:[~2015-12-08 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 18:33 Prarit Bhargava
2015-12-08 23:30 ` Jacob Pan [this message]
2015-12-09 0:12 ` Seiichi Ikarashi
2015-12-09 13:27 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208153016.0dcebee1@icelake \
--to=jacob.jun.pan@linux.intel.com \
--cc=ajay.thomas.david.rajamanickam@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minipli@googlemail.com \
--cc=prarit@redhat.com \
--cc=radivoje.jovanovic@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=s.ikarashi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome