From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750829AbbLHQ5G (ORCPT ); Tue, 8 Dec 2015 11:57:06 -0500 Received: from casper.infradead.org ([85.118.1.10]:53068 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733AbbLHQ5D (ORCPT ); Tue, 8 Dec 2015 11:57:03 -0500 Date: Tue, 8 Dec 2015 17:57:00 +0100 From: Peter Zijlstra To: Alexander Shishkin Cc: Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, johannes@sipsolutions.net, Arnaldo Carvalho de Melo Subject: Re: [PATCH 2/7] perf: Generalize task_function_call()ers Message-ID: <20151208165700.GE6357@twins.programming.kicks-ass.net> References: <1449138762-15194-1-git-send-email-alexander.shishkin@linux.intel.com> <1449138762-15194-3-git-send-email-alexander.shishkin@linux.intel.com> <20151203173431.GC3816@twins.programming.kicks-ass.net> <87vb88yjs6.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87vb88yjs6.fsf@ashishki-desk.ger.corp.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 08, 2015 at 06:42:01PM +0200, Alexander Shishkin wrote: > > +void ___perf_event_disable(void *info) > > Only maybe change these to __perf_event_disable_locked() or something > visually distinctive from the 'active' callback? Yeah, I ran out of naming-foo and punted. I'll give it another go tomorrow.