From: Mark Brown <broonie@kernel.org>
To: Xiubo Li <lixiubo@cmss.chinamobile.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: speed up the regcache_init()
Date: Tue, 8 Dec 2015 17:05:17 +0000 [thread overview]
Message-ID: <20151208170517.GU5727@sirena.org.uk> (raw)
In-Reply-To: <1449109150-26793-1-git-send-email-lixiubo@cmss.chinamobile.com>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
On Thu, Dec 03, 2015 at 10:19:10AM +0800, Xiubo Li wrote:
> If the cache is not used by the device driver, there is not need to
> check the striding of the registers. It will just return 0 from
> regcache_init() and let the register striding be checked in proper
> place when needed.
> - for (i = 0; i < config->num_reg_defaults; i++)
> - if (config->reg_defaults[i].reg % map->reg_stride)
> - return -EINVAL;
> -
> if (map->cache_type == REGCACHE_NONE) {
> map->cache_bypass = true;
> return 0;
> }
If we're not using the register cache why are there defaults in the
first place?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-12-08 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 2:19 Xiubo Li
2015-12-08 17:05 ` Mark Brown [this message]
2015-12-09 3:17 ` Xiubo Li
2015-12-09 15:05 ` Mark Brown
2015-12-10 1:37 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208170517.GU5727@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixiubo@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®