From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752118AbbLHTA2 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Dec 2015 14:00:28 -0500
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:38051 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751961AbbLHTA0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Dec 2015 14:00:26 -0500
Date: Tue, 8 Dec 2015 19:00:05 +0000
From: Mark Brown <broonie@kernel.org>
To: Damien Horsley <Damien.Horsley@imgtec.com>
Cc: alsa-devel@alsa-project.org, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        James Hartley <james.hartley@imgtec.com>
Message-ID: <20151208190005.GY5727@sirena.org.uk>
References: <1449594324-2597-1-git-send-email-Damien.Horsley@imgtec.com>
 <1449594324-2597-3-git-send-email-Damien.Horsley@imgtec.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="9QtXyXGM8HCrXlir"
Content-Disposition: inline
In-Reply-To: <1449594324-2597-3-git-send-email-Damien.Horsley@imgtec.com>
X-Cookie: revolutionary, adj.:
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: 94.175.94.161
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH V2 2/2] ASoC: img: Add driver for Pistachio internal DAC
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--9QtXyXGM8HCrXlir
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Dec 08, 2015 at 05:05:24PM +0000, Damien Horsley wrote:

> +static int pistachio_internal_dac_set_mute(struct snd_kcontrol *kcontrol,
> +				  struct snd_ctl_elem_value *ucontrol)
> +{
> +	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
> +	struct pistachio_internal_dac *dac = snd_soc_codec_get_drvdata(codec);
> +	u32 reg;
> +
> +	dac->mute = ucontrol->value.integer.value[0];
> +
> +	if (dac->mute)
> +		reg = PISTACHIO_INTERNAL_DAC_CTRL_MUTE_MASK;
> +	else
> +		reg = 0;
> +
> +	regmap_update_bits(dac->regmap, PISTACHIO_INTERNAL_DAC_CTRL,
> +			PISTACHIO_INTERNAL_DAC_CTRL_MUTE_MASK, reg);
> +
> +	return 0;
> +}

Shouldn't this just be a standard SOC_SINGLE() now?  We've got a regmap.
Otherwise this looks good.

--9QtXyXGM8HCrXlir
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWZyi1AAoJECTWi3JdVIfQNgkH/A79T4Olc1ZhHbUlIiaJXBuU
m2PWGTCJ/y+yjbD6tCSfhSfQ3hs+nDhij/HiMKjYrr3DnUg3w1/eL4ND9a5bEqrr
wCfpfF9EMEanqgch7C5zCksrDRDJVIU77I3AnvGiC0OVrauPnbT0nkpjnqEzSZDo
xBRQcVUT5jshPD9VtD2Ps4EYiw3YInosrn0CCXykchbUIoLfNkF9lrSrSCB/8aR+
v24tT9m+SNRgfk1VH1lT4nI+kHKvxkZXoz+PJVYFbyGBg48jnvYMJoEICj1ZJQyq
mqoqKnlV1OJdfPhVRgCcLaHBFmMS46BGhq5PgSpc3glihVuWi6KI8TNv8h/GjU4=
=ih2Z
-----END PGP SIGNATURE-----

--9QtXyXGM8HCrXlir--