From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752103AbbLIA2s (ORCPT ); Tue, 8 Dec 2015 19:28:48 -0500 Received: from smtprelay0205.hostedemail.com ([216.40.44.205]:59951 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751442AbbLIA2q (ORCPT ); Tue, 8 Dec 2015 19:28:46 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 30,2,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2736:2893:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3872:3873:3874:4321:5007:6119:6261:7875:7903:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12114:12296:12438:12517:12519:12555:12740:13069:13073:13208:13229:13311:13357:13523:13524:14659:21067:21080:30030:30034:30054:30089:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: bag32_86a2bb32fe643 X-Filterd-Recvd-Size: 2248 Date: Tue, 8 Dec 2015 19:28:44 -0500 From: Steven Rostedt To: Michael Ellerman Cc: LKML , linuxppc-dev@lists.ozlabs.org, chuhu@redhat.com Subject: Re: [RFC][PATCH] ppc: Implement save_stack_trace_regs() Message-ID: <20151208192844.70fb33e6@gandalf.local.home> In-Reply-To: <1449620422.6028.6.camel@ellerman.id.au> References: <20151208135056.718b7668@gandalf.local.home> <1449620422.6028.6.camel@ellerman.id.au> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 Dec 2015 11:20:22 +1100 Michael Ellerman wrote: > On Tue, 2015-12-08 at 13:50 -0500, Steven Rostedt wrote: > > > It has come to my attention that kprobe event stack tracing does not > > work on powerpc. > > Yep looks like you're right. I didn't realise it was separate from the regular > stack trace stuff. > > > diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c > > index ea43a347a104..0142c86801ba 100644 > > --- a/arch/powerpc/kernel/stacktrace.c > > +++ b/arch/powerpc/kernel/stacktrace.c > > @@ -61,3 +61,10 @@ void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace) > > save_context_stack(trace, tsk->thread.ksp, tsk, 0); > > } > > EXPORT_SYMBOL_GPL(save_stack_trace_tsk); > > + > > +void > > +save_stack_trace_regs(struct pt_regs *regs, struct stack_trace *trace) > > +{ > > + save_context_stack(trace, regs->gpr[PT_R1], current, 0); > > In the kernel we would normally use just '1' here rather than 'PT_R1', but it's > not a huge deal. > > Should I take this via powerpc or do you want it to go in via tracing? > You can take it. And you can replace the PT_R1 if you want. I just noticed that it was defined, and I try to use macro names instead of hard coded numbers. I was actually looking for a "PT_SP" :-) -- Steve