Re: [PATCH 06/14] crashdump/cris: Add print_crashkernel_region_size() function

From: Dave Young <dyoung@redhat.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com,
	horms@verge.net.au, keir@xen.org, david.vrabel@citrix.com,
	konrad.wilk@oracle.com
Subject: Re: [PATCH 06/14] crashdump/cris: Add print_crashkernel_region_size() function
Date: Wed, 9 Dec 2015 10:55:39 +0800	[thread overview]
Message-ID: <20151209025539.GD14426@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <1449611867-15672-7-git-send-email-daniel.kiper@oracle.com>

On 12/08/15 at 10:57pm, Daniel Kiper wrote:
> Provide just print_crashkernel_region_size() stub. This way
> we can properly build kexec utility on cris arch even
> if the functionality is not available on it.
> 
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> ---
>  kexec/arch/cris/kexec-cris.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/kexec/arch/cris/kexec-cris.c b/kexec/arch/cris/kexec-cris.c
> index 4ac2f89..8c62191 100644
> --- a/kexec/arch/cris/kexec-cris.c
> +++ b/kexec/arch/cris/kexec-cris.c
> @@ -77,6 +77,11 @@ int is_crashkernel_mem_reserved(void)
>  	return 0;
>  }
>  
> +void print_crashkernel_region_size(void)
> +{
> +	printf("-1\n");

"-1" is meaningless to end user, how about instead telling that there's no
such functionality for the arch.

> +}
> +
>  unsigned long virt_to_phys(unsigned long addr)
>  {
>  	return (addr) & 0x7fffffff;
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 
> 