From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Nitin Gupta <nitin.gupta@samsung.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shivnandan Kumar <shivnandan.k@samsung.com>,
Vidushi Koul <vidushi.koul@samsung.com>,
Gaurav Kohli <gaurav.k6@samsung.com>,
Rajat Suri <rajat.suri@samsung.com>,
Shailesh Pandey <p.shailesh@samsung.com>,
"shiv.jnumca08@gmail.com" <shiv.jnumca08@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] char:misc minor is overflowing
Date: Wed, 9 Dec 2015 13:35:33 +0000 [thread overview]
Message-ID: <20151209133533.29040318@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1925385281.482851449665491986.JavaMail.weblogic@epmlwas08d>
On Wed, 09 Dec 2015 12:51:33 +0000 (GMT)
Nitin Gupta <nitin.gupta@samsung.com> wrote:
> Hi,
>
> Is there any modification / improvement needed in this patch ?
>
> ------- Original Message -------
> Sender : Shivnandan Kumar<shivnandan.k@samsung.com> Engineer/SRI-Noida-Advance Solutions - System 1 R&D Group/Samsung Electronics
> Date : Nov 20, 2015 15:35 (GMT+05:30)
> Title : [PATCH] char:misc minor is overflowing
>
> When a driver register as a misc driver and
> it tries to allocate minor number dynamically.
> Then there is a chance of minor number overflow.
> The problem is that 64(DYNAMIC_MINORS) is not enough
If you are allocating more than the odd minor number you shouldn't be
using misc devices in the first place but should be using
cdev_init/cdev_add/register_chrdev_region and friends.
So 64 really should never be "not enough". miscdevice is more historical
than useful and really goes back to the days long before all the region
allocators existed.
Alan
next prev parent reply other threads:[~2015-12-09 13:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 12:51 Fwd: " Nitin Gupta
2015-12-09 13:35 ` One Thousand Gnomes [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-11-20 10:05 Shivnandan Kumar
2015-12-21 21:43 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209133533.29040318@lxorguk.ukuu.org.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=gaurav.k6@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nitin.gupta@samsung.com \
--cc=p.shailesh@samsung.com \
--cc=rajat.suri@samsung.com \
--cc=shiv.jnumca08@gmail.com \
--cc=shivnandan.k@samsung.com \
--cc=vidushi.koul@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®