From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755201AbbLLAfo (ORCPT ); Fri, 11 Dec 2015 19:35:44 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:57239 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754308AbbLLAfF (ORCPT ); Fri, 11 Dec 2015 19:35:05 -0500 Date: Fri, 11 Dec 2015 19:35:03 -0500 (EST) Message-Id: <20151211.193503.312733505035879098.davem@davemloft.net> To: arnd@arndb.de Cc: netdev@vger.kernel.org, w-kwok2@ti.com, m-karicheri2@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] netcp: add more __le32 annotations From: David Miller In-Reply-To: <6435706.peaM34LhnV@wuerfel> References: <1578620.t1ANcREMZ8@wuerfel> <6435706.peaM34LhnV@wuerfel> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 11 Dec 2015 16:35:05 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Tue, 08 Dec 2015 16:32:59 +0100 > The handling of epib and psdata remains a bit unclear in the driver, > as we access the same fields both as CPU-endian and through DMA > from the device. > > Sparse warns about this: > ti/netcp_core.c:1147:21: warning: incorrect type in assignment (different base types) > ti/netcp_core.c:1147:21: expected unsigned int [usertype] *[assigned] epib > ti/netcp_core.c:1147:21: got restricted __le32 * > > This uses __le32 types in a few places and uses __force where the code > looks fishy. The previous patch should really have produced the correct > behavior, but this second patch is needed to shut up the warnings about > it. Ideally it would be slightly rewritten to not need those casts, > but I don't dare do that without access to the hardware for proper > testing. > > Signed-off-by: Arnd Bergmann Applied to net-next.