From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754060AbbLKIhO (ORCPT ); Fri, 11 Dec 2015 03:37:14 -0500 Received: from mga14.intel.com ([192.55.52.115]:56839 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752366AbbLKIhM (ORCPT ); Fri, 11 Dec 2015 03:37:12 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,412,1444719600"; d="scan'208";a="858669990" Date: Fri, 11 Dec 2015 10:37:05 +0200 From: Heikki Krogerus To: Noam Camus Cc: "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , "gregkh@linuxfoundation.org" , "jslaby@suse.com" , "peter@hurleysoftware.com" , "fransklaver@gmail.com" , "Alexey.Brodkin@synopsys.com" , "vgupta@synopsys.com" , Andy Shevchenko Subject: Re: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses Message-ID: <20151211083705.GF4884@kuha.fi.intel.com> References: <45xw80lci7vs893wq469l1b0.1449765214447@com.syntomo.email> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45xw80lci7vs893wq469l1b0.1449765214447@com.syntomo.email> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Noam, On Thu, Dec 10, 2015 at 04:33:39PM +0000, Noam Camus wrote: > Please see > https://lkml.org/lkml/2015/8/3/806 > Why I added private accessors. Greg is not saying anything about the iotype checking there? Looks more like confusion about what exactly is that patch trying to achieve. I think Greg just thought you moved the writel call from the beginning of the function to be called later inside the "else" condition. You need to start your series with a patch where you just separate the lcr checking to its own function and follow that with patches where you introduce the big-endian support. I think this is also what Andy told you. Use the diff I gave you. One more thing that I forgot to comment before: s/dw8250_check_LCR/dw8250_check_lcr/ Thanks, -- heikki