From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755362AbbLKQ7K (ORCPT <rfc822;w@1wt.eu>);
	Fri, 11 Dec 2015 11:59:10 -0500
Received: from bombadil.infradead.org ([198.137.202.9]:47802 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751624AbbLKQ7J (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 11 Dec 2015 11:59:09 -0500
Date: Fri, 11 Dec 2015 17:59:04 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        vince@deater.net, eranian@google.com,
        Arnaldo Carvalho de Melo <acme@infradead.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH v0 3/5] perf: Introduce instruction trace filtering
Message-ID: <20151211165904.GB6356@twins.programming.kicks-ass.net>
References: <1449840998-29902-1-git-send-email-alexander.shishkin@linux.intel.com>
 <1449840998-29902-4-git-send-email-alexander.shishkin@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1449840998-29902-4-git-send-email-alexander.shishkin@linux.intel.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 11, 2015 at 03:36:36PM +0200, Alexander Shishkin wrote:
> +static int
> +perf_event_set_itrace_filter(struct perf_event *event, char *filter_str)
> +{
> +	int ret = 0;
> +
> +	/*
> +	 * Since this is called in perf_ioctl() path, we're already holding
> +	 * ctx::mutex.
> +	 */
> +	lockdep_assert_held(&event->ctx->mutex);
> +
> +	/*
> +	 * For now, we only support filtering in per-task events; doing so
> +	 * for cpu-wide events requires additional context switching trickery,
> +	 * since same object code will be mapped at different virtual
> +	 * addresses in different processes.
> +	 */
> +	if (!event->ctx->task)
> +		return -EOPNOTSUPP;
> +
> +	/* remove existing filters, if any */
> +	perf_itrace_filters_clear(event);
> +
> +	ret = perf_event_parse_itrace_filter(event, filter_str);
> +	if (!ret) {
> +		perf_itrace_filters_apply(event);
> +
> +		ret = perf_event_itrace_filters_setup(event);
> +		if (ret)
> +			perf_itrace_filters_clear(event);

This is what I meant, if you try and set a 'wrong' filter while it
already has filters set, you'll not only error out, you'll also wipe the
current state.

This seems wrong.

> +	}
> +
> +	return ret;
> +}