From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753555AbbLKTzS (ORCPT ); Fri, 11 Dec 2015 14:55:18 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:34057 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753460AbbLKTzM (ORCPT ); Fri, 11 Dec 2015 14:55:12 -0500 Date: Fri, 11 Dec 2015 11:55:09 -0800 From: Christoph Hellwig To: Mike Christie Cc: device-mapper development , Mikulas Patocka , Jens Axboe , Mike Snitzer , linux-scsi@vger.kernel.org, "Martin K. Petersen" , "James E.J. Bottomley" , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [dm-devel] [PATCH 0/15] copy offload patches Message-ID: <20151211195509.GA2217@infradead.org> References: <566A59BC.9060305@cs.wisc.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <566A59BC.9060305@cs.wisc.edu> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 10, 2015 at 11:06:04PM -0600, Mike Christie wrote: > > 2. Start REQ_OP_READ off at non-zero to try and shake out code that was > not converted. > > There are a several places where we assume reads are zero and writes are > 1 for things like indexing in arrays (like blktrace's ddir_act or dm > starts), passing into block functions (like nvme_alloc_request's call of > blk_mq_alloc_request), and if/else's. I am not done fixing all of them > and testing. If this turns out to be too painful we should just skip it. I though it would be a nie debugging aid, but we don't need to do it at any cost.