From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Bogicevic Sasa <brutallesale@gmail.com>
Cc: bhelgaas@google.com, Richard.Zhu@freescale.com,
l.stach@penguintronix.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:pci:host Fix missing line after declarations
Date: Sat, 12 Dec 2015 13:23:16 +0100 [thread overview]
Message-ID: <20151212132316.27e10a6d@free-electrons.com> (raw)
In-Reply-To: <1449920508-105873-1-git-send-email-brutallesale@gmail.com>
Dear Bogicevic Sasa,
On Sat, 12 Dec 2015 03:41:48 -0800, Bogicevic Sasa wrote:
> This fixes few warnings about missing line after declarations and one
> no whitespace is necesarry before that "("
>
> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
I am not a big fan of this struct rule that insists in having an empty
line after declarations, I believe when a for() loop or if() condition
has only one line of declaration and one line of useful code, it
doesn't make much sense. But oh well, that's the rule, so let's do it
this way.
> ---
> drivers/pci/host/pci-imx6.c | 2 +-
> drivers/pci/host/pci-mvebu.c | 3 +++
> drivers/pci/host/pcie-rcar.c | 2 ++
> 3 files changed, 6 insertions(+), 1 deletion(-)
For the pci-mvebu.c part:
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-12 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 11:41 Bogicevic Sasa
2015-12-12 12:23 ` Thomas Petazzoni [this message]
2015-12-12 13:03 ` sasa bogicevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151212132316.27e10a6d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=Richard.Zhu@freescale.com \
--cc=bhelgaas@google.com \
--cc=brutallesale@gmail.com \
--cc=l.stach@penguintronix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®